Skip to content

clean unnecessary copy #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 21, 2025
Merged

clean unnecessary copy #1133

merged 5 commits into from
Mar 21, 2025

Conversation

rsoaresd
Copy link
Contributor

@rsoaresd rsoaresd commented Mar 17, 2025 •
edited
Loading

This was referenced Mar 18, 2025
Merged
Merged
Merged
Merged
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, metlos, mfrancisc, rsoaresd, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,fbm3307,metlos,mfrancisc,rsoaresd,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek
Copy link
Collaborator

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2025
@MatousJobanek
Copy link
Collaborator

it's actually the same problem with pairing multiple PRs again. I didn't notice that :-) You either need to use different branch name or merge the one of the other PRs and delete the branch there first and then re-run this again.

@rsoaresd
Copy link
Contributor Author

@MatousJobanek i noticed here and on the was side. i will be more careful next time, I promise

@openshift-ci openshift-ci bot removed the lgtm label Mar 20, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alexeykazakov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 63ca319 into codeready-toolchain:master Mar 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos approved these changes

@xcoulon xcoulon xcoulon approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@mfrancisc mfrancisc mfrancisc approved these changes

@fbm3307 fbm3307 fbm3307 approved these changes

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek

@rajivnathan rajivnathan Awaiting requested review from rajivnathan

@ranakan19 ranakan19 Awaiting requested review from ranakan19

@jrosental jrosental Awaiting requested review from jrosental

Assignees

@alexeykazakov alexeykazakov

@MatousJobanek MatousJobanek

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rsoaresd @MatousJobanek @alexeykazakov @metlos @xcoulon @mfrancisc @fbm3307